Changing Heading level loses Tab / Shift + Tab connection

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.35k stars 4.13k forks source link

Changing Heading level loses Tab / Shift + Tab connection #55745

Open jeryj opened 10 months ago

jeryj commented 10 months ago

Description

When changing the heading level on a heading block or site title block, shift and shift + tab do not work to move between block and tools. The connection works as expected until changing the heading level.

Step-by-step reproduction instructions

Using the floating block toolbar...
Add a heading block
Shift + Tab to move focus to the block tools
Tab back to the block to see that it works correctly
Shift + Tab to move focus to the block tools
Select a new heading level
Tab does not return you to the block

Screenshots, screen recording, code snippet

https://github.com/WordPress/gutenberg/assets/967608/72743bd0-7467-4039-b493-5f85f07a67a6

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

YukinobuAsakawa commented 10 months ago

I'm curious about this issue.I tried testing it and it looked like this. It seems that even if you follow the reproduction procedure, you cannot return to the block.

Environment tested
WordPress Version:6.4.1
Gutenberg Version 17.0.0

joedolson commented 10 months ago

I wasn't able to reproduce this using Gutenberg 17.0.2/WordPress 6.5-alpha-57114/Windows 11/Chrome or Firefox. It worked as expected. What's the OS/browser in use where you're getting this?

joedolson commented 10 months ago

OK, so with some additional exploration, I was able to reproduce it. It does happen with all plugins disabled; but if any plugin is adding a meta box to the page (I was using JSM Show Post Metadata), then it works as expected.

I didn't do any exploration to try and figure out why; it was a surprising result.

github-actions[bot] commented 9 months ago

Hi, This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps. Thanks for helping out.

4hiroramos commented 2 months ago

Hi, thank you for your issue. I've tried it, and I see why you mentioned it as a problem.

However, when I used it for building paragraph blocks, it didn't matter. But, the heading block still has a problem.

WP 6.6
Guteberg 18.8.0
PHP8.0

tbshiki commented 2 months ago

Hi, I have reproduced the same situation.

Environment tested
WordPress Version:6.6
Gutenberg Version 18.8.0

After adding a heading block, pressing Shift + TAB to focus on "The floating block toolbar", changing the heading level, and confirming with Enter, I found that when I pressed the TAB key, the focus/cursor disappeared.

In the case of a paragraph block, when I changed the "Align text" option, pressed Enter, and then pressed the TAB key, the focus moved to the paragraph block.

I noticed that the behavior differs between heading block and paragraph block.