Open afercia opened 11 months ago
@afercia I tend to agree but also note that some popovers don't take focus by default. The AutocompleteUI
for example.
CC: @getdave.
Thanks @alexstine
I started looking into dialogs on Link Control here https://github.com/WordPress/gutenberg/pull/54063 although it's clearly a work in progress and should be considered with that in mind.
I think related...the tab behavior in the Link Control edit mode within the Patterns context is suboptimal. Additionally, this Link Control behavior in the Patterns context is inconsistent with same control in the post editor context.
Steps to reproduce:
https://github.com/user-attachments/assets/6dc16e79-0008-471b-9fb2-94b61dbcae7a
Description
Splitting this out from https://github.com/WordPress/gutenberg/pull/56042#issuecomment-1807695604
Turns out most of the popovers in the editor UI do implement constrained tabbing but some don't. I'm not sure what the reasoning behing this inconsistent is, but I'd tend to think all the popovers should implement a consistent keyboard interaction, regardless whether the component is 'inline' within the post content or in other parts of the UI.
Step-by-step reproduction instructions
There may be other instances of popovers where tabbing is not constrained. To me, it seems there is no good reason why popovers should not constrain tabbing. The keyboard interaction should always be the same: predictable and consistent. I'd like to hear thoughts also from @alexstine and @joedolson
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes