WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.47k stars 4.18k forks source link

Bottom metaboxes float over the editing window in Chrome #5653

Closed xenobytezero closed 6 years ago

xenobytezero commented 6 years ago

Issue Overview

Metaboxes that appear at the bottom of the editing panel float over the editing blocks in Chrome 64/65

Steps to Reproduce (for bugs)

Tested with Chrome 65 / 66.0.3359.33 Does not appear in Edge 41.16299.248.0 Gutenberg Plugin 2.4.0

  1. Ensure you have a plugin that creates a metabox at the bottom of the main editing page (CoAuthor Plus for instance)
  2. Edit a post in Gutenberg that is longer than a single screen

Expected Behavior

The "Authors" metabox exists at the bottom of the page under all of the editing blocks

Current Behavior

The "Authors" metabox floats over the editing blocks

Possible Solution

It seems like the .edit-post-visual-editor element does not encompass all of the content, and instead just sets its height to 100% of the window. This means the footer metaboxes sit just under 100% height

Screenshots / Video

ss

youknowriad commented 6 years ago

I can't reproduce this myself, any particularity about this setup or the post content?

xenobytezero commented 6 years ago

Can't think of anything that is specific to my setup.

capture

xenobytezero commented 6 years ago

In DevTools, changing the .edit-post-visual-editor.editor-writing-flow element to remove the height:100% rule fixes the issue but creates a large space between the bottom of the actual post and the bottom metaboxes

xenobytezero commented 6 years ago

So it turns out this appears to be related to the fact that the CoAuthors plugin. If I deactivate that plugin then the metaboxes appear to be fine.

The CoAuthors plugin currently produces a number of notices when activated with Gutenberg (#5654). It's currently unclear if this is due to the notices on the page or if the plugin itself is doing this.

If this plugin is deactivated, everything seems to behave, tested with a custom ACF metabox.

karmatosed commented 6 years ago

Unless I am mistaken this seems to be the plugin issue over Gutenberg. As a result going to close this, I would encourage reaching out to the plugin author. This can be reopened if needed.

mazzopalazzo commented 5 years ago

Bump.

Still there on Version 77.0.3865.75 (Official Build) beta (64-bit)

johnReeve commented 5 years ago

We are having a similar issue. I have not been able to diagnose the root cause, but the symptom is the same. Works fine in Firefox but breaks in Chrome (macOS) If I mess with

.edit-post-layout__content .edit-post-visual-editor { flex-basis: 100%; }

it will modify how this is failing.

lkraav commented 5 years ago

Hi. I can also reproduce this and so can my users. This might be some kind of a regression specifically with Chrome 77.