search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.4k stars 4.16k forks source link

Social Links Block: update Patreon Logo #56925

Closed evalarumbe closed 8 months ago

evalarumbe commented 10 months ago

What problem does this address?

Patreon recently updated their logo. We may want to update the Patreon logo or add a new one in the Social Links block to match the new branding.

This issue is near identical to the recent Twitter/X logo update by @jeherve: https://github.com/WordPress/gutenberg/issues/53223

What is your proposed solution?

The solution would likely be very similar to this merged PR, which addresses the recent issue for Twitter/X: https://github.com/WordPress/gutenberg/pull/54092/files

The above PR adds a new icon, rather than replacing the old one. For this issue, I would propose a similar solution, so users can decide which to use, since brand recognition for the new logo may not be widespread yet.

Patreon provides SVGs for download in their Brand assets and guidelines.

evalarumbe commented 10 months ago

Hi there @jeherve, I'm considering taking this one myself as my first contribution to Gutenberg. I'm just getting started reading the contribution docs.

t-hamano commented 9 months ago

Thank you for your suggestion, @evalarumbe.

The difficult part about this issue is that unlike Twitter/X, the brand name has not changed, only the logo has been updated.

I tried to find out if the Gutenberg project had ever changed just the logo. The only case I found was on Tumblr where only the logo was updated (#21329). In this case, the changes in the logo were small, so the logo was probably updated directly.

As for the Patreo logo, it seems like the logo has changed a lot.

Old (Actual appearance in social link block):

old

New (From guidelines):

new

Personally, I don't think it's necessary to create a new block if only the logo changes. It seems that the Font Awesome project has also updated the logo directly (https://github.com/FortAwesome/Font-Awesome/issues/19936).

jeherve commented 9 months ago

I don't think it's necessary to create a new block if only the logo changes.

I would agree. I would only update the logo and colors. #56951 should take care of that.

evalarumbe commented 9 months ago

I would agree. I would only update the logo and colors. https://github.com/WordPress/gutenberg/pull/56951 should take care of that.

Nice, should I close this issue then? Looks like you'll get to it before I'm done with setup, so by all means get this merged and I'll find another ticket to get started with.

jeherve commented 9 months ago

@evalarumbe We can keep this issue opened! 👍 It will get automatically closed when / if the Pull Request I linked to will be merged.

evalarumbe commented 8 months ago

I'm still interested in seeing this shipped, but I don't have permissions to review it myself. Is there a recommended way of politely bumping it so it isn't forgotten? I'm still getting used to the pace of WP contributions. How often would it be recommended to bump without making too much noise?