WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.41k stars 4.16k forks source link

Media/Text: Ensure that existing image size configurations are applied to replacements #58878

Open codebymikey opened 7 months ago

codebymikey commented 7 months ago

Description

When you have an existing block with image size controls, when you replace the media, it should reuse the existing image size controls (or potentially reset it once you've placed a new image).

Might be related to #55027

Step-by-step reproduction instructions

  1. Go to an existing editor e.g. https://wordpress.org/gutenberg/
  2. Create a "Media & Text" block.
  3. Pick an image and change the resolution to Thumbnail.
  4. Use the toolbar to replace with a different media from the Media Library.
  5. The "Media & Text" block is now using the default full sized media, but it's still set as "Thumbnail" in the resolution leading to an inconsistent state.

It should either attempt to persist the original resolution, and removing the resolution if it's not supported, or just always reset the resolution whenever the URL is updated.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

github-actions[bot] commented 6 months ago

Hi, This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps. Thanks for helping out.

github-actions[bot] commented 5 months ago

Hi, This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps. Thanks for helping out.

akasunil commented 3 months ago

Came here to report this, and I'm glad to see it's already been worked on.