search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.46k stars 4.18k forks source link

Advancing site editor index views #59659

Closed SaxonF closed 3 months ago

SaxonF commented 7 months ago

Related https://github.com/WordPress/gutenberg/issues/55083 https://github.com/WordPress/gutenberg/issues/53322

What problem does this address?

As part of the admin track of work we want to start adopting some of the new UX paradigms within the site editor index views.

https://github.com/WordPress/gutenberg/assets/1072756/8fe4bd09-694c-44d7-b9a9-c91d6c87d56c

Pages and templates within the site editor currently drill-down the navigation sidebar showing a list of records, but what we want to work towards is always using the "content frame" for lists, including the "side by side" layout type which lets you quickly preview posts before editing. This also solves the weird "manage pages" and "manage templates" links that currently exist. The goal of this work is bring those "manage" pages forward so they are visible when visiting /pages or /templates, much like /patterns.

Tasks

Site editor responsiveness

Replace current pages with manage pages

Replace the existing pages view that shows pages in sidebar and update with the "manage pages" view. For this piece of work we can keep the "custom views" as experimental.

Old

image

New

image

Criteria:

Replace current templates with manage pages

Much like pages, we want to do the same for templates.

Old

image

New

image

Criteria:

Updates patterns to remove template parts management

The current patterns page makes use of the new data views but we still have a "manage template parts" link. We should aim to remove that link and bring the missing functionality over to the patterns view.

Criteria:

youknowriad commented 7 months ago

Thanks for opening this issue, these are some nice flows.

Left sidebar remains at the top level with "templates" selected UNLESS "custom views" experiment is enabled

I think this one is going to be challenging to pull off, I'd navigate to "custom views" (or default views if the experiment is disabled) on the first iteration. We'd need stronger routing to be able to stay in the top view in the sidebar while navigating to templates.

"Manage template parts" link should go away

This item is also to be addressed with care, currently the patterns list view doesn't show "template parts", so it might mean "merging them", adding fields to filter one or the other... It might require its own issue for clarity.

oandregal commented 7 months ago

Index for templates https://github.com/WordPress/gutenberg/pull/59792

@SaxonF the screenshot for templates uses the table layout, though the texts mentions grid layout. Which one should be the default? The PR uses the existing (table).

oandregal commented 7 months ago

https://github.com/WordPress/gutenberg/pull/59858 makes the list layout stable, so it becomes available for Pages, Templates, and Parts without the experiment enabled.

oandregal commented 7 months ago

Updates index for pages https://github.com/WordPress/gutenberg/pull/59950

oandregal commented 7 months ago

https://github.com/WordPress/gutenberg/pull/60069 explores using grid layout for templates.

annezazu commented 6 months ago

Adding the tracking label to this as it tracks work across the experience and is part of the broader Overview issue of Data Views and Admin Redesign.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60337 enables table layout for patterns.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60345 removes "Manage all of my patterns" link.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60359 looks at template parts in patterns (needs feedback on target design).

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60409 to display the content frame for Pages in mobile.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60372 adds the author field & filter to the template parts in the Patterns page.

getdave commented 6 months ago

I'm wondering if any of this work should/could be extended to the Navigation (Menus) section?

In the past, we've received feedback that users would like to be able to edit (including ability to create) menus within the sidebar but I'm not sure that (especially editing) fits with the new UX paradigm outlined here.

Questions:

  1. Do we see Navigation making use of these new data views?
  2. Do we think Navigation Menus should be partially editable from these views, and if so how would that work?

Update: I noticed in https://github.com/WordPress/gutenberg/issues/53322 there is a UI (see Example of the "drill down" below) which allows for drill down into individual entities from the "List" layout. This drill down could expose the UI for editing the Navigation Menu.

Example of the "drill down" Screen Shot 2024-04-10 at 10 56 43

Also I notice the term "Navigation" is being used a lot to described moving through "stacks" in the UI. That's fine, but just noting we may need to be careful to distinguish menus by referring to them as "Navigation Menus".

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60659 adds edit and viewRevision actions to parts in Patterns page.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60667 sets the backPath for Template Parts to the Patterns page.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60689 removes the "Manage all parts" link, page, and code.

oandregal commented 6 months ago

https://github.com/WordPress/gutenberg/pull/60775 adds a "All template parts" section in the Patterns sidebar. It's a pre-requisite for https://github.com/WordPress/gutenberg/pull/60689.

oandregal commented 6 months ago

There's been a lot of activity in the Patterns screen and we're almost there: https://github.com/WordPress/gutenberg/pull/60689 removes the "Manage template parts" link and old code. After this one lands, I'm focusing a bit on the DataViews component again – improving the list layout with actions, etc.

oandregal commented 5 months ago

https://github.com/WordPress/gutenberg/pull/60689 has landed and all listed tasks for Patterns are implemented. It's been a bit more involved than expected, and there's probably other things we need to polish now that this is ready.

Next, I'm planning to look at the task related to the DataViews component (list layout).

SaxonF commented 5 months ago

I wanted to highlight this issue because although it is not directly tied to data views it does become more important to solve after we've added the new 3 column layout. Once we close this work out, and the inspector, we should follow it up with responsive changes.

oandregal commented 5 months ago

Based on @jameskoster comment, I've added some more tasks for consolidating Patterns/Parts:

Consolidate Patterns & Template Parts categories (https://github.com/WordPress/gutenberg/pull/60689#issuecomment-2071970132):

oandregal commented 5 months ago

https://github.com/WordPress/gutenberg/pull/60805 landed adding "edit" & "all actions" buttons in list layout for all index views that support it (pages, templates).

oandregal commented 5 months ago

Update on my availability for this: I have some upcoming AFK in a few days and won't be able to be back at this until the week of the 27th.

jameskoster commented 5 months ago

In case anyone is able to pick up the work here in @oandregal's absence, it would be really great if the following could be closed out for 6.6:

Most of them are small adjustments, so hopefully we can get it done 🤞

oandregal commented 5 months ago

Pages data view: clarify 'Date' field

PR at https://github.com/WordPress/gutenberg/issues/60477

oandregal commented 5 months ago

Pages data view: Update title field so that homepage and posts page are marked with a badge

PR at https://github.com/WordPress/gutenberg/pull/61718

oandregal commented 4 months ago

custom views for pages include default views [All, Published, Draft, Scheduled, Utility, Trash]

https://github.com/WordPress/gutenberg/pull/62021 adds the missing Published & Scheduled items.

I've left "Utility" out. I presume it's related to this discussion about "utility pages", for which there's an ongoing conversation — it can be addressed separately.

oandregal commented 4 months ago

Custom views for templates include default views [All, pages, posts, utility, custom]

https://github.com/WordPress/gutenberg/pull/62075 addresses the preliminary steps to implement the above: it adds the postType & isCustom fields & filters to the templates page.

jameskoster commented 3 months ago

Most of the items here have been addressed, so I think we can close this one out.

I've tracked any relevant outstanding items in a new tracking issue for 6.7: https://github.com/WordPress/gutenberg/issues/63128