search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.52k stars 4.21k forks source link

Black border around the navigation items when sub items are present #59944

Open tomxygen opened 8 months ago

tomxygen commented 8 months ago

Description

When a sub-menu item is present, when clicking on the sub-menu item or on the parent menu item, a black border is shown around the items. See the screen recording attached.

Step-by-step reproduction instructions

  1. go to the site editor
  2. add a navigation block
  3. add an item and a sub item
  4. publish changes and visit the site
  5. click on the sub-menu item and on the parent item
  6. see the black border as in the screen recording attached.

Screenshots, screen recording, code snippet

https://github.com/WordPress/gutenberg/assets/47855768/eacb8234-6ea8-4ade-9f04-5512ffe3e676

Environment info

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

annezazu commented 8 months ago

I could replicate with RC2. @getdave can you look into this? Here's what I saw:

https://github.com/WordPress/gutenberg/assets/26996883/ec33d217-375e-493b-8185-33504f0d29ab

Adding to triage for now.

getdave commented 8 months ago

I could replicate with RC2. @getdave can you look into this? Here's what I saw:

Adding to my todos for tomorrow.

getdave commented 8 months ago
Screen Shot 2024-03-19 at 10 23 43

I've confirmed this issue and I can see the selector that is causing it. ~I'm now going to track down where that came from.~

This seems to come from the Theme. In this case it's TT4. I tested with TT3 and the issue is not in evidence,

What is more, the issue applies to any link that gains focus not just in the Nav block.

As a result I'm removing the Nav block specific labels.

getdave commented 8 months ago

@MaggieCabrera This seems like it could be TT4 specific. Are you able to offer any insight here?

MaggieCabrera commented 8 months ago

@MaggieCabrera This seems like it could be TT4 specific. Are you able to offer any insight here?

I think it comes from https://core.trac.wordpress.org/changeset/57739 This probably requires a theme specific trac ticket, rather than a Gutenberg issue

getdave commented 8 months ago

Thanks @MaggieCabrera. I'm going to remove this from the WP 6.5 board as it's not 6.5 specific.

However we should look to resolve in TT4.

annezazu commented 8 months ago

Thank you all for sleuthing this!

jordesign commented 8 months ago

Thanks folks - Trac ticket is created: https://core.trac.wordpress.org/ticket/60808#ticket