search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.52k stars 4.21k forks source link

Remove inline page status from Navigation Link blocks #60057

Open richtabor opened 8 months ago

richtabor commented 8 months ago

It's unintuitive to have a page status within a navigation item's text label. I can't act on the information from this view, and there's no where for me to change this label that seems like it will be like this on my site.

A better alternative would be to not add status to what look like the front-end of the site, but rather include it in the UI elsewhere, perhaps in the Block Toolbar, or the Inspector.

Visual

Here's what we have currently:

CleanShot 2024-03-20 at 17 41 21

Here's a potential alternative, although the popover contents may rely on using tokens in relevant navigation link blocks:

https://github.com/WordPress/gutenberg/assets/1813435/d64f5bd4-3cd1-4ccd-8730-4cc03950fdcb

Any other ideas?

jasmussen commented 8 months ago

The current state is definitely one of reaching parity rather than being the best design. This improves the experience and makes it actionable, but comes with the tradeoff that it gets less clear that a page item is in a draft state and therefore doesn't show up on the frontend. To that end, we can think of a page item in draft state as a placeholder — it only ever shows up in the editor. Is there a different visual treatment to denote this for a page item in the unselected state?

richtabor commented 8 months ago

I don't love an opacity change to denote placeholder, but I'm not sure what else.

jasmussen commented 8 months ago

but I'm not sure what else

That's the thing: suffixing (draft) is clumsy, to be sure, but it seems fairly clear and obvious in terms of denoting, this one is in a different state, that's why you're not seeing it on the frontend. We can make the draft name into a little chip, perhaps?

I follow you though, the canvas is never a good place for anything that isn't actual content. So I'm mainly suggesting that absent a solid idea, it's just not clear that removing the (draft) is a step forward. Not a strong opinion, though, happy to try.

richtabor commented 7 months ago

What if the draft chip was in the LinkControl preview, rather than on the canvas? Next to the title.

jasmussen commented 7 months ago

To be clear, I'm happy to move forward with an alternative approach.

One thing we didn't discuss, is the squiggly line under the nav item. Perhaps that, combined with the chipo inside the link control preview, is sufficient? The squiggly line was added to both denote unlinked menu items, and drafts, as it's conceptually equivalent to a grammar tool.