search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.37k stars 4.15k forks source link

Vertical rhythm changes after updating to WP 6.5 #60240

Open janboddez opened 6 months ago

janboddez commented 6 months ago

Description

Some of my site's blockquotes (Quote blocks) got an is-layout-flow class applied to them.

This caused their first and last child element to lose their, respectively, top and bottom margin. Which cause certain, but not all, quotes, to look off.

Also, the editor's title wrapper no longer got a bottom margin equal to the default block gap (which I guess may have been a conscious choice; my theme also doesn't apply a bottom margin to titles, but I like the vertical whitespace in the context of the editor).

Step-by-step reproduction instructions

  1. Have a blockquote block with one paragraph in it.
  2. And another with more children.
  3. And then a few more.
  4. Watch how they're styled differently after upgrading to WP 6.5.

I'm not sure why some of my quotes seem unaffected; most of them are.

Screenshots, screen recording, code snippet

Before: Screenshot 2024-03-27 105603

After: image

Environment info

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

janboddez commented 5 months ago

I'm not sure why some of my quotes seem unaffected; most of them are.

Turns out I had some "normal" blockquotes with a wp-block-quote added to them. These were unaffected.

Only the "true" Quote blocks now (as of WP 6.5) get is-layout-flow added to them. Revert to WP 6.4.3 and the issue is gone (and so is the class).

Now I understand that you probably want to remove start and end margins inside of blocks like these, and rely on the parent's (i.e., the block itself) padding instead. I.e., I get the change. But it's a breaking change nonetheless.