WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.55k stars 4.22k forks source link

Components: remove Framer Motion #60975

Open DaniGuardiola opened 7 months ago

DaniGuardiola commented 7 months ago

This is a tracking issue. There has been some discussion of removing Framer Motion (the use of motion especially), citing a few arguments:

Current situation

Framer Motion is wrapped in the components package (packages/components/src/animation/index.tsx). A few utilities are re-exported from it, including the motion component.

Those wrappers are then used both internally and externally in a few places. This issue tracks those instances as we transition out of them.

Strategy

A good start would be removing all instance of internal usage within the components package.

In a second stage, external uses within Gutenberg could be removed as well.

Then, we should set the component as deprecated and nudge potential consumers (if any) towards either using CSS directly (preferred), using a lightweight alternative like motion.dev, or at least using framer-motion directly, as we don't want to officially support it anymore from the components package.

Finally, the re-exports should be deleted, or if we feel like an intermediate phase is useful, replaced by mock functions that throw errors asking users to migrate before completely deleting a few versions after.

Internal instances

External instances

youknowriad commented 7 months ago

If we are able to achieve the same results, I think that's fine but I think we should probably leave the deprecation as the last step after removing all usage in Gutenberg. We don't want core's codebase to trigger deprecation messages.

DaniGuardiola commented 7 months ago

@youknowriad agreed, updated the strategy in the issue description.

DaniGuardiola commented 6 months ago

Another reason: it seems like it won't support React 19 for a good while, as the maintainers have run into a lot of trouble

@diegohaz discussed this on the bird platform: https://x.com/diegohaz/status/1793164208571638155

anomiex commented 2 months ago

I note that framer-motion v11.5.0 has deprecated their motion() function in favor of motion.create(). Given the plans in this issue to remove framer-motion entirely I don't know whether you'll want to fix that or ignore it / stick with 11.4.0 until this is completed.