search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.48k stars 4.18k forks source link

Focus ring doesn't match button Site Hub Icon size #61339

Open jeryj opened 5 months ago

jeryj commented 5 months ago

Description

The site icon in the header of the site editor has a smaller focus ring.

Step-by-step reproduction instructions

  1. Use the keyboard to move focus to the site hub button
  2. The focus ring does not match the size of the site hub button

Screenshots, screen recording, code snippet

Open Navigation tooltip with focus ring about 8px inside of the edge of the site icon

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

vipul0425 commented 5 months ago

@jeryj I have raised the PR to fix this issue.

Thanks.

kNoCoding commented 4 months ago

so is the issue solved? should i try to fix it?

jeryj commented 4 months ago

We're needing design feedback on https://github.com/WordPress/gutenberg/pull/61350, as the focus ring is hard to see in the fix.

karthick-murugan commented 2 weeks ago

@jeryj I have raised this PR to close this issue.