WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
9.99k stars 4.01k forks source link

Post Inspector: Move taxonomy term select UI (categories + tags) to updated summary panel #61852

Open jameskoster opened 1 month ago

jameskoster commented 1 month ago

Follow-up to https://github.com/WordPress/gutenberg/issues/59689

Currently taxonomy selection occurs in dedicated panels. Ideally these should follow the Discussion and Author panels into the Summary section:

Current Proposed
Screenshot 2024-05-22 at 09 49 32 Screenshot 2024-05-22 at 09 51 32
Mamaduka commented 1 month ago

It would be nice to account for multiple, dozen and more designs for these panels from the start.

I've done my fair share of work on these components and have seen people assigning 30+ tags to a post.

jameskoster commented 1 month ago

@Mamaduka there's some discussion about that here: https://github.com/WordPress/gutenberg/pull/61492#issuecomment-2122537847

Mamaduka commented 1 month ago

@jameskoster, I'm following that discussion as well.

These panels are a bit different from the others in that area as they have to display multiple values, unlike others, where the panel trigger button usually has a single string value.

jameskoster commented 1 month ago

Could the label not be a truncated, comma separated list of all values?

cats-and-tags

Alternatively, perhaps something like;

cats-and-tags

If we decide it's necessary that all terms are visible then a more comprehensive solution could be an autocomplete/combobox component. Similar to what we have now, but with some visual tweaks to make it more at home inside the summary panel:

cats-and-tags
jasmussen commented 1 month ago

I'd agree, not sure it's good to consolidate everything into this card. Notably tags feels best omitted from here, same with categories and custom taxonomies. And should sticky move into "Status"?

jameskoster commented 1 month ago

Notably tags feels best omitted from here

@jasmussen Where do you think they should live?

jasmussen commented 1 month ago

My instinct is that the summary panel as a whole works well as a colophon, in terms of the size and contents without tags and categories. And that as soon as you add those, it grows vertically to the point that it loses some of that "overview" feeling, and starts becoming more of an everything-panel. It's also not clear it improves the usability of the individual controls as they exist in panels today.

That's not to say it can't work. But just that the panel as it exists in trunk, even with existing tag and category panels, would be a big refinement and change to ship in 6.6. We could then, early in the 6.7 phase, decide based on 6.6 feedback whether absorbing those remaining panels is a natural evolution of the work, or whether they have better utility as separate panels.

So I'd keep the panels as they are.

jameskoster commented 1 month ago

And that as soon as you add those, it grows vertically to the point that it loses some of that "overview" feeling

Just to note, the plans originally set out in https://github.com/WordPress/gutenberg/issues/59689 included combining status + publish date, and moving template to a 'Design' panel. So even with categories and tags there would only be 6 items here.

A reminder of what we're shooting for:

Screenshot 2024-05-23 at 14 15 10

Some of those are longer-term changes though. So waiting for 6.7 seems reasonable even if (imo) it leaves the summary panel feeling a little unfinished for 6.6.