search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.32k stars 4.12k forks source link

Comments Pagination: Remove unwanted bottom margin from links #62114

Open iamtakashi opened 3 months ago

iamtakashi commented 3 months ago

Similar to #51299, the Comments Next Page, Comments Previous Page, and Comments Page Numbers blocks have unwanted bottom margins. I don't see why we need them, and they are creating misalignments in themes.

CleanShot 2024-05-29 at 18 26 31@2x

We can't get rid of it in Global Styles in the editor, we can't get rid of it in the theme.json, and the custom CSS is getting overridden by default as well.

CleanShot 2024-05-29 at 18 29 36@2x

Can we just remove the default bottom margin for all three blocks?

t-hamano commented 3 months ago

This margin appears to have been there since the block itself was added: https://github.com/WordPress/gutenberg/pull/36872

@cbravobernal If you know why this margin was necessary, I would appreciate it if you could tell us 🙏

cbravobernal commented 3 months ago

To be honest I do not remember. I guess I copied the styles that were on the non-block version.

t-hamano commented 1 month ago

I'm starting to think that the ideal solution to this problem would be to deprecate the Comments Pagination block. See #64318 for more details.