WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
9.99k stars 4.02k forks source link

The post title shown in the editor UI should not use the Verse block icon #62186

Open afercia opened 1 month ago

afercia commented 1 month ago

Description

Splitting this out from https://github.com/WordPress/gutenberg/pull/62136#issuecomment-2141963224

Icons should be used to uniquely identify features and controls of a user interface.

It appears that's not the case for the 'verse' icon. After recent changes to the editor top bad and the Post settings panel, the verse icon is used in association with the ppst title shown in the UI. And it is still used for the Verse block. I'm not sure that's ideal, under all aspects.

Does the Post title shown in the ui need an icon in the first place?

Screenshot:

Screenshot 2024-05-31 at 13 46 37

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

richtabor commented 1 month ago

Perhaps verse should have a different icon? They certainly shouldn't be the same.

afercia commented 1 month ago

Just adding that the verse icon is used also for the 'Add citation` button in the Quote block, which doesn't help with creating a cohesive visual language:

Screenshot 2024-06-03 at 10 17 01

afercia commented 1 month ago

One more usage of the verse icon is for the 'blog page' in the link suggestions:

Screenshot 2024-06-03 at 10 34 30

afercia commented 1 month ago

One more usage is in the 'Add new template' modal dialog, when the 'blog home' template is missing:

Screenshot 2024-06-03 at 11 39 10