search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
9.99k stars 4.01k forks source link

Navigation: Make 'Manage menus' button link to site-editor.php?postType=wp_navigation #62257

Open noisysocks opened 1 month ago

noisysocks commented 1 month ago

I was testing creating a block-based website from scratch and got confused when I came across this very sad looking 'Mange menus' link that appears in the Advanced panel when a Navigation block is selected:

Screenshot 2024-06-03 at 15 25 31

  1. It looks unpolished. Should it be a variant="secondary" button and not a link?

  2. I'd expect it to be located with the other menu management controls:

    Screenshot 2024-06-04 at 12 05 07

  3. I'd expect it to link to site-editor.php?postType=wp_navigation and not edit.php?post_type=wp_navigation which is very clunky and requires the user to save/discard their changes.

jasmussen commented 3 weeks ago

Good issue. I would link it to the site editor navigation section (/wp-admin/site-editor.php?postType=wp_navigation), however, which I would expect to get the new data views in the not too distant future.

noisysocks commented 3 weeks ago

@jasmussen: Do you think we should move it to the ellipsis menu or keep it in Advanced?

jasmussen commented 3 weeks ago

It's been in the ellipsis menu before, in fact it's moved around a bit. I recall personally advocating for the ellipsis menu, since there's a dedicated Navigation section in the site editor. But I'm also generally deferring to feedback here, so it may be best to keep it where it is.

There's an open question of the classic themes behavior here.