WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.49k stars 4.19k forks source link

Difficulties for interacting with the image block when is in a circle form with a small size #63254

Open jesusyesares opened 3 months ago

jesusyesares commented 3 months ago

Description

Bug Report

Description

Trying one of the patterns in Twenty-Twenty-Four Theme, I tried to change the image of a cite. This image is inside a circle form in a group block. Is something like this:

CleanShot 2024-07-08 at 13 38 43@2x

The properties of the block are something like this:

CleanShot 2024-07-08 at 13 39 18@2x

The problem is that there's no access to the upload button or the Media library. If you want to access to this buttons, you have to increase the width and the height or change the aspect ratio to Original as you can see here.

CleanShot 2024-07-08 at 13 40 57@2x

CleanShot 2024-07-08 at 13 41 35@2x

Or you can do this:

CleanShot 2024-07-08 at 13 41 27@2x

CleanShot 2024-07-08 at 13 41 04@2x

Step-by-step reproduction instructions

Steps to Reproduce

  1. In the Twenty Twenty Four Theme.
  2. In the home page.
  3. Go to the Testimonial Block.

CleanShot 2024-07-08 at 16 46 42@2x

  1. 🐞 Bug occurs.

Expected Results

  1. ✅ At least it must be possible to access to the images from the lateral panel under the block attributes.

CleanShot 2024-07-08 at 13 41 04@2x

Actual Results

  1. ❌ What actually happened.

CleanShot 2024-07-08 at 13 38 43@2x

CleanShot 2024-07-08 at 13 40 57@2x

Screenshots, screen recording, code snippet

No response

Environment info

Environment

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

jasmussen commented 3 months ago

Good issue. This is something we need to address, and I just referred to this issue from #63327 which details the Site Logo placeholder state which actually addresses the issue at hand here, but could be improved with a better tooltip placement and controls in the inspector.

The Site Logo presents a path forward for how to address this issue. I'd love to hear from @WordPress/gutenberg-design if they agree. Depending on discussion I would then think both of these issues can be fixed together.

jameskoster commented 3 months ago

I agree in general. The Featured Image block is the same (when page editing) and works quite well:

Screenshot 2024-07-10 at 11 47 42

But these block's on-canvas UX are missing a way to 'Insert from URL'. In the case of regular images, maybe the Upload button should open a menu with options: "Upload", "Media library", "Insert from URL"?

jasmussen commented 2 months ago

This issue will be fixed by #64320.