WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.46k stars 4.18k forks source link

Multi-entity save: reverse order of save and cancel buttons when saving in the frame #63372

Open annezazu opened 3 months ago

annezazu commented 3 months ago

When saving changes in the frame rather than in the canvas, the order of the buttons should be reversed to make it more obvious to click the primary call to action ("save"). Generally, the primary action for items is often found on the right side.

Current:

Screenshot 2024-07-10 at 10 30 04 AM

Proposed

Screenshot 2024-07-10 at 10 35 47 AM

Of note, currently when saving in the canvas/editor, we show a similar order to the current and I wonder if we should also update there:

Screenshot 2024-07-10 at 10 36 55 AM

cc @WordPress/gutenberg-design for more context and thoughts.

jasmussen commented 3 months ago

I would think both of these interfaces could use substantial design refreshes. But that shouldn't block this.

jameskoster commented 3 months ago

I wonder if we should also update there

That will probably be necessary to avoid falling foul of a11y requirements (visual order should match DOM order).

richtabor commented 3 months ago

One note: if the save and cancel buttons are inverted in the second publish sidebar, when you press Save and the sidebar opens up, you'll press the cancel button almost immediately.

jasmussen commented 3 months ago

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

Option

Figma.

richtabor commented 3 months ago

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

If we do, should the Inspector icon always be first next to it? So that it's consistently in the same place?

jasmussen commented 2 months ago

Yes, like so, good catch: