WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.51k stars 4.2k forks source link

block-insertion-points missing between innerBlock-elements #64222

Open digitalex11 opened 3 months ago

digitalex11 commented 3 months ago

Description

I have two problems with block-insertion-points (lines with plus icon) in my custom blocks:

1. block with innerBlocks with orientation: horizontal with line-break block-insertion-points are not appearing when mouse hovers between elements in second line, in first line everything is working as expected.

2. block with scrolled innerBlocks content this problem occurs in a custom horizontal slider component (also innerBlocks with orientation: horizontal): block-insertion-points are not appearing when mouse hovers between elements that are not in the initially visible area (when slider is scrolled)

case 1 could also be reproduced in the core/buttons block (see step by step instructions)

buttons

Step-by-step reproduction instructions

  1. create a core/buttons block
  2. create multiple buttons inside core/buttons so that the buttons break into a second line
  3. mouse-hover between buttons in second line: block-insertion-point will not appear

Screenshots, screen recording, code snippet

No response

Environment info

I am using: MAC OS 13.4.1 Chrome 127.0.6533.88 Wordpress 6.6.1

Please confirm that you have searched existing issues in the repo.

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Mamaduka commented 3 months ago

@digitalex11, does the in-between inserter work correctly on the second line if you select the very first block on the first line?

This might be the same issue as #53315. My comment provides additional details: https://github.com/WordPress/gutenberg/issues/53315#issuecomment-1941555587.

t-hamano commented 3 months ago

I was just testing this issue and it seems that the in-between inserter does not work on wrapped blocks, regardless of what block is selected.

Similar problems seem to occur in the Social Icons block and the Row block as well.

https://github.com/user-attachments/assets/ac95eabd-1210-4715-954f-ac470cc1c4b5

digitalex11 commented 3 months ago

@Mamaduka , no, the problem also occurs if first block ist selected. @t-hamano , thanks for your video. Thats exactly the problem. It also occurs on the Grid block. It seems to affect all blocks with orientation: horizontal and line-breaks

digitalex11 commented 3 months ago

Here a video of the second case in my slider block:

https://github.com/user-attachments/assets/a3766271-a938-4298-8478-7dabb4be27eb

t-hamano commented 3 months ago

64229 was automatically linked to close this issue, but note that #64229 does not resolve this issue.

Mamaduka commented 3 months ago

@t-hamano, we should re-open this correct?

t-hamano commented 3 months ago

Yes, thanks for noticing 😅