Open ndiego opened 3 months ago
Hi @ndiego, I would like to work on the issue.
Thank You,
Hi @ndiego, I have created a draft PR - https://github.com/WordPress/gutenberg/pull/64330, but I am seeing this PR needs lots of refactoring once the main referenced PR - https://github.com/WordPress/gutenberg/pull/63401/ is merged and working. This is because we can use a lot of things from the PR so we do not have redundant code issue happening.
Also, there are ongoing discussion happening on the typography supports stabilization, hence I am aiming to wait for the typography support stabilizing to get merged in trunk and then we can pick up the pace on this issue with the PR.
Though, I have once concern about the border
supports, as the whole border
is defined as experimental
and not the inner supports, so if you can look at quickly on the PR if that is the way we can achieve to stabilize the border and have some initial feedbacks on the approach.
Thank You,
@hbhalodia yes, any PR for this issue should follow the similar approach outlined in https://github.com/WordPress/gutenberg/pull/63401. I would also recommend waiting until that PR is successfully merged.
Thanks for the response, we can wait until https://github.com/WordPress/gutenberg/pull/63401 PR gets merged.
suspense! I hope it'll be backward compatible
https://github.com/WordPress/gutenberg/pull/63401 has been merged, so I think we're in a good spot to move forward on the border support stabilization. I've left a review on @hbhalodia's PR, https://github.com/WordPress/gutenberg/pull/64330.
I'm happy to pick up any block support stabilization tasks or move the existing efforts forward.
As discussed on #64330, I've spun up a fresh PR (https://github.com/WordPress/gutenberg/pull/66918) that expands on the stabilization approach pioneered via #63401. I plan to give it some testing tomorrow and will then flag it as being ready for review.
Kudos and props to @hbhalodia and @benazeer-ben for all their work to date 🙇
I'll close the other open PRs so we can push the latest approach across the line.
Related to:
Borrowing from the format of https://github.com/WordPress/gutenberg/issues/63001, this issue outlines the tasks needed to stabilize the
__experimentalBorder
support. Doing so will make it easier for third-party extenders to confidently build custom blocks that provide border support and modify existing blocks with this support.Note that in order to provide backward compatibility for block plugins out in the wild, fallback support for the existing
__experimental
prefix should be provided.Stabilize the following border block support and associated properties:
__experimentalBorder
→border
__experimentalBorder.color
→border.color
__experimentalBorder.radius
→border.radius
__experimentalBorder.style
→border.style
__experimentalBorder.width
→border.width
Tasks
lib/block-supports/border.php
to use the non__experimental
prefix, falling back to the__experimental
prefix if available.__experimental
prefix, falling back to the__experimental
prefix if available.block.json
schema to support the non__experimental
prefixblock.json
files to use the non__experimental
prefixesblock.json
schema to remove the__experimental
prefix. Note that the code in WordPress should still support the__experimental
prefix, but at this stage, the experimental prefix will be treated as deprecated.The PR for this stabilization effort should follow the approach used to stabilize the typography supports in https://github.com/WordPress/gutenberg/pull/63401.