search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.51k stars 4.2k forks source link

Placeholders to render theme colors alongside custom colors #64734

Closed javiercasares closed 3 days ago

javiercasares commented 2 months ago

Description

Having in mind that, probably, the theme colors are “more important” than the personalized colors, when you have both, blocks only show the personalized colors by default in the block (for example, in the Cover block), although in the sidebar all colors appears correctly.

Tested in WordPress 6.6.

Step-by-step reproduction instructions

  1. Have some theme colors (not personalized colors).
  2. Add a Cover block. It shows to pick one theme color.
  3. Add some personalized colors.
  4. Add a cover block. It only shows the personalized colors in the block. In the sidebar are all the colors.

Screenshots, screen recording, code snippet

Cover only with personalized colors Text only with personalized colors Cover Sidebar with all the colors

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Please confirm that you have tested with all plugins deactivated except Gutenberg.

ndiego commented 2 months ago

Yup, I can confirm. This behavior is a bit strange.

TT4 With Custom Colors
image
TT4 Without Custom Colors
image
AKSHAT2802 commented 2 weeks ago

Hii @javiercasares. This issue seems to be connected to https://github.com/WordPress/gutenberg/issues/64857.

I have raised a PR for the solution.PR Link. Please reach out in case of any suggestions or feedback :)

richtabor commented 3 days ago

This issue seems to be connected to https://github.com/WordPress/gutenberg/issues/64857.

Yes, this is a duplicate of #64857. Let's close this and push that one ahead as there is more discussion there.