search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Remove purple coloring from DocumentBar #65168

Closed richtabor closed 3 weeks ago

richtabor commented 2 months ago

As an affordance, the purple color applied in the DocumentBar is not helping to communicate the "global" nature of templates, synced patterns, and template parts. It's just not connective in this presentation, and with the addition of post type labels in https://github.com/WordPress/gutenberg/issues/65167 — arguably, not necessary.

I propose we simplify a bit, removing the purple color within the DocumentBar.

Current

current

Proposed

proposed
creativecoder commented 2 months ago

Looking at this, I see we use color: var(--wp-block-synced-color); in a number of other places, too, here are some that I found:

List View Template Parts

image

Template Part Block Toolbar

image

Template Part Block Info

image

Template Title

image

I think this should be consistent, e.g. if the color isn't used for template text in the DocumentBar, then don't use it in the Template info (sidebar) either.

Same for the icon, (unless it's removed from the DocumentBar, see https://github.com/WordPress/gutenberg/issues/65167)

richtabor commented 1 month ago

I think this should be consistent, e.g. if the color isn't used for template text in the DocumentBar, then don't use it in the Template info (sidebar) either.

This yes, but the template part block icon is block-level, so I think it's fine to leave it purple in canvas—for now at least.