"Set featured image" button border flashes on focus

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.47k stars 4.18k forks source link

Closed mirka closed 6 days ago

mirka commented 1 month ago

In a post, go to the Post tab in the sidebar and move the keyboard focus onto the "Set featured image" button.

The focus ring shows like the other components.

There is a lag between the focus ring appearing and the normal border disappearing.

t-hamano commented 1 week ago

My guess is that this issue is related to #66007, because the "Set featured image" variation button also has an inset box shadow applied by default.

Vrishabhsk commented 1 week ago

Hi @mirka 👋

I have resolved this issue in this PR : https://github.com/WordPress/gutenberg/pull/66092
The solution implemented was discussed in this issue and PR

Let me know your thoughts on this. Thanks. cc: @tyxla

tyxla commented 6 days ago

Thanks for working to resolve the "Set featured image" issue @Vrishabhsk 🙌