search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.52k stars 4.21k forks source link

Normalize placement of Link Icon for Button block #65366

Open getdave opened 2 months ago

getdave commented 2 months ago

Does the link control in the button need to be different? cc @getdave

I understand that you mean you'd like the Link icon to be in the same place as it is on the paragraph block? I think it's just an accident of the ordering of items which we may be able to fix up easily 🤞

Originally posted by @getdave in https://github.com/WordPress/gutenberg/issues/65204#issuecomment-2352386255

getdave commented 2 months ago

cc @richtabor

fabiankaegy commented 2 months ago

There is a reason why they are in different places thought 🤔

the one on the paragraph (any any blocks that contain RichText elements) this is the formatting toolbar that showcases all inline formats. These options only apply to the current text selection.

On the button however the link doesn't have anything to do with the text selection but instead applies to the entire block.