Tabs: select tab id and visual highlight are out of sync when removing tab

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.41k stars 4.16k forks source link

Tabs: select tab id and visual highlight are out of sync when removing tab #65576

Open ciampo opened 1 week ago

ciampo commented 1 week ago

This can be currently reproduced in Storybook:

https://github.com/user-attachments/assets/053c0d0e-8f53-4cfb-9416-3c58d8655493

ciampo commented 1 week ago

cc @DaniGuardiola

DaniGuardiola commented 1 week ago

Yep, I'm aware of this one and have a simple solution already on my mind, just need to get through the in-progress stuff and then I'll handle this. Thanks for reporting.

ciampo commented 4 days ago

Just flagging that this bug "evolved" after the latest work on Tabs, and now manifests differently (and arguably providing a worse UX):

https://github.com/user-attachments/assets/cf52d0e6-9319-4dd4-9d19-27421dc6e02e

DaniGuardiola commented 4 days ago

Thanks, yeah makes sense that the bug evolved like this, I'm gonna fix this as my next priority as I follow up on the Tabs and ToggleGroupControl work by cleaning things up and sharing a bit more code.