Audit blocks for writing and contentOnly modes

talldan commented 1 month ago

Description

contentOnly mode is becoming more prevalent in the editor after 'Select Mode: Use the content-only behavior in select mode' was merged.

Lots of block types still aren't working perfectly in contentOnly mode, so this list intends to capture those issues so that they can be worked on in parallel by multiple devs. Lots of the blocks also share similar issues, so hopefully there are higher-level solutions to the problems that can be found (lets discuss these in the comments).

Feel free to add more to this issue if you discover untracked issues.

Blocks

Buttons

[ ] User cannot add/remove individual buttons

Cover

[ ] Background image cannot be modified (should it be possible to modify this?)
[ ] Initial block placeholder can't be interacted with in contentOnly mode (possibly the same issue as above).

Details

[ ] Details block appears as a single 'Paragraph' in the Inspector Content panel

File

PR: https://github.com/WordPress/gutenberg/pull/65787

[x] Block is completely non-interactive, including the placeholder

Gallery

[ ] Placeholder is non-interactive in contentOnly mode.
[ ] Users cannot add/remove items (should they be able to?)

List

PR: https://github.com/WordPress/gutenberg/pull/65836

[ ] Users cannot add/remove list items from the list block or nest list items (how should nested list items appear in the Inspector content panel?)
[ ] List Items currently have a special case in the code to prevent them appearing in the Inspector Content panel (a more general solution to this should be found as other container blocks will have the same kind of problem for their inner blocks): https://github.com/WordPress/gutenberg/blob/df27bd934838d56271224c76d54402886b88160c/packages/block-editor/src/components/block-inspector/index.js#L242

Media / Text

[ ] Additional paragraphs can't be added in the content area of the block (similar to Quote)
[ ] In the Inspector panel, the paragraph that's inside the Media Text block appears after it (again, similar to Quote)

More

[ ] User cannot edit 'Read more' text

Navigation

[ ] Cannot be edited (see https://github.com/WordPress/gutenberg/issues/65699)

Post Title / Featured Image / Excerpt

[ ] Blocks cannot be edited (they have no attributes suitable for the role: content declaration)

Quote

[ ] The paragraph that's inside the Quote appears after the Quote block in the Inspector Content panel (to repro, add a quote block inside a group, apply contentOnly templateLock to the group, and select the group.)
[ ] Users cannot add more paragraphs (should they be able to? If so should they also be able to add other types of blocks? How do these appear in the Inspector Content panel?)

Site Logo / Site Title / Site Tagline

[ ] Blocks cannot be edited (they have no attributes suitable for the role: content declaration)

Social Link

[ ] https://github.com/WordPress/gutenberg/pull/66622

Table

[ ] Block is completely non-editable in contentOnly mode, including the initial placeholder

youknowriad commented 1 month ago

For blocks like "list" and "quote", their "inner blocks area" should be marked as "content" somehow it seems. But how far do we take this: is "cover" block's inner blocks also "content"? I guess not but the line is very blurry, in some situations I would love to be able to add paragraphs within "already designed cover blocks" for instance.

talldan commented 1 month ago

For blocks like "list" and "quote", their "inner blocks area" should be marked as "content" somehow it seems. But how far do we take this: is "cover" block's inner blocks also "content"? I guess not but the line is very blurry, in some situations I would love to be able to add paragraphs within "already designed cover blocks" for instance.

Yep, it does feel a bit blurry. Also whether only paragraphs can be added to Quote/Cover or other types of content blocks too.

Heading and List might be other basic text blocks that are candidates. Then List is itself a container, so this is where the flat content structure in contentOnly mode starts to become more challenging to represent.

richtabor commented 1 month ago

For blocks like "list" and "quote", their "inner blocks area" should be marked as "content" somehow it seems. But how far do we take this: is "cover" block's inner blocks also "content"?

The most straightforward move is to solve for repeatable inner blocks, like Button within Buttons block, and List Item within the List block first. Where if you press enter, another of the same block is inserted.

talldan commented 1 month ago

File block was an easy one to fix so I've made a PR - https://github.com/WordPress/gutenberg/pull/65787.

I've also been experimenting with the List block with mixed results. I'll try to get a PR up soon.

richtabor commented 1 month ago

For blocks like "list" and "quote", their "inner blocks area" should be marked as "content" somehow it seems.

annezazu commented 3 weeks ago

I just tested Write/Design mode with a few themes and want to underscore the following as we need these:

Site Title/Site Logo: for themes that have a "link in bio" feel, this completely breaks the experience as you can't edit much of the main pieces you would want to.
Navigation: for any theme, I'd want to be able to edit navigation.

Blocks I think should be on the list:

Social Icons: it's odd that you can't edit these, especially if you think about a link in bio site

https://github.com/user-attachments/assets/0d4b957a-00fa-46bf-9606-b2dbef274db4

Query Loop block: strange experience where you can edit the "no results" text but nothing else. I think we should expand what's available in block settings in line with what's described here so there's a more visual and clearer action to take: https://github.com/WordPress/gutenberg/issues/63497

https://github.com/user-attachments/assets/e55b8961-64ce-4f7c-a146-669f59bdebf9

annezazu commented 3 weeks ago

Just did user testing with a friend and want to underscore featured image block too. They couldn't select it and, as a result, didn't know what it was or where it would show up! Here's a quick video demoing how awkward this is, audio included:

https://github.com/user-attachments/assets/18d76431-f342-4be1-ad6f-ef557552884e

Finally, they also ran into issues with the site tagline where it says "write your site tagline" prompt yet they can't select it. Pretty confusing!

WordPress / gutenberg