WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.46k stars 4.18k forks source link

Zoom out: drag and drop zones behave strangely (disappear, bounce, etc) #65927

Open annezazu opened 1 week ago

annezazu commented 1 week ago

When playing around with drag and drop, I noticed that the zones behave a bit strangely:

Appearing then disappearing.
"Bouncing" where the drop zone quickly moves up and down trying to expand.
Patterns with grid block causes a large overlay to appear with grid lines

https://github.com/user-attachments/assets/51c8359f-5dc9-44b7-99f0-f5cfd70e8fcc

This was found using WordPress 6.7 nightly.

richtabor commented 1 week ago

Patterns with grid block causes a large overlay to appear with grid lines

65974

richtabor commented 1 week ago

What behavior were you expecting?

ndiego commented 2 days ago

Since RC1 is occurring later today and there is no active PR, I think we should punt this to 6.8. Thoughts @colorful-tones @getdave @kevin940726?

colorful-tones commented 2 days ago

Since RC1 is occurring later today and there is no active PR, I think we should punt this to 6.8.

Agree 👍

getdave commented 2 days ago

This bug was introduced during this cycle. Therefore I see no reason to punt it at this stage. Can we reassess as we move through RC?

colorful-tones commented 2 days ago

This bug was introduced during this cycle

@getdave Wouldn't this make it a regression if it was introduced into the WordPress 6.7 release cycle and it was not in the WordPress 6.6 release? 🤔

getdave commented 2 days ago

The Zoom Out feature was introduced during this 6.7 cycle. At some point the experience referenced in this Issue changed and provided a suboptimal experience. Happy to label it however you'd prefer, but ultimately it would be better to fix it 👍

ndiego commented 2 days ago

The Zoom Out feature was introduced during this 6.7 cycle. At some point the experience referenced in this Issue changed and provided a suboptimal experience. Happy to label it however you'd prefer, but ultimately it would be better to fix it 👍

Sounds good, let's reassess as we move further through the release cycle.

stokesman commented 1 day ago

I expect #66110 may have slightly alleviated some of this because it makes for less displacement. Still, I’d suggest that the displacement while dragging is maybe more harmful than helpful for two reasons:

It lends to the false impression that the drop target is only there, when actually if the separator/zone is visible you’re already over the drop target. This is exacerbated by the prompt text and background color animation when dragged over.
Shifting the layout in response to the pointer is what seems to make "bouncing" possible and in the case of the first or last insertion points makes it easier to overshoot the zone you’re trying to drag to.

My feeling is that a drop indicator without displacement while dragging would be better. This version with displacement could be saved for when an inserter button was clicked to basically serve as a help message.