No focus style for Open Navigation button - Githubissues

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.48k stars 4.18k forks source link

No focus style for Open Navigation button #66375

Open jeryj opened 1 day ago

jeryj commented 1 day ago

Description

There are no focus styles for the Open Navigation button on the site editor header.

Step-by-step reproduction instructions

Move focus to the "Open Navigation" button in the site editor header
Open Navigation tooltip will be visible but no focus styles are present

Screenshots, screen recording, code snippet

Open Navigation tooltip but no focus style

Environment info

No response

Please confirm that you have searched existing issues in the repo.

[x] Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

[x] Yes

Please confirm which theme type you used for testing.

[ ] Block
[ ] Classic
[ ] Hybrid (e.g. classic with theme.json)
[ ] Not sure

vipul0425 commented 1 day ago

Hi @jeryj Do we have any design reference for this? Applying the default focus styles might cause visibility issues, similar to what we’re seeing here: https://github.com/WordPress/gutenberg/pull/61350#pullrequestreview-2038409489 ?

For ref:

jeryj commented 1 day ago

Pinging @WordPress/gutenberg-design to see how we can best show the focus style for this state.