Global styles revisions close button overlaps scrollbar - Githubissues

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.55k stars 4.22k forks source link

Global styles revisions close button overlaps scrollbar #66435

Open stokesman opened 1 month ago

stokesman commented 1 month ago

Description

The close button overlaps the scrollbar, maybe this isn’t as much an issue with overlaid scrollbars.

For comparison, because the Style Book has a header it avoids the issue. Maybe adding a header in revisions is a potential fix.

Step-by-step reproduction instructions

Open "Revisions" from the "Styles" sidebar
See if the close button is overlapping the scrollbar

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

[x] Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

[x] Yes

Please confirm which theme type you used for testing.

[x] Block
[ ] Classic
[ ] Hybrid (e.g. classic with theme.json)
[ ] Not sure

Vrishabhsk commented 1 month ago

Hi @stokesman 👋

Raised a PR for fixing this : https://github.com/WordPress/gutenberg/pull/66456
Feels a bit janky using aria-label="Close revisions" in the selector but couldn't find an alternative to target the button, but let me know if you know of a better approach.

Let me know your thoughts on it. Thanks