WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.49k stars 4.19k forks source link

Revert 66431 (Site editor: remove "default" admin CSS) #66540

Closed andrewserong closed 4 days ago

andrewserong commented 4 days ago

What?

Reverts #66431

Why?

While a well-intentioned change to remove unnecessary CSS, it turns out #66431 caused a regression in the site editor in mobile viewport sizes where the admin markup is exposed unexpectedly.

A longer-term solution might be to see if we can skip the admin markup entirely for site-editor.php, however for now, in order to ensure things are working well on trunk, this PR proposes reverting.

How?

Revert the change in #66431

Testing Instructions

  1. On trunk open up the site editor in a mobile viewport size. Notice that above the content of the site editor the WP admin UI markup is unexpectedly displayed.
  2. With this PR applied, the site editor should work as it did before on mobile and other viewport sizes

Screenshots or screencast

Before After
image image
github-actions[bot] commented 4 days ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

andrewserong commented 4 days ago

Thanks for the quick reviews! 🙇