Closed ramonjd closed 2 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Flaky tests detected in bace479a86c5915a20e5ded8fbdb66b00a69c4c6. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11585143275 📝 Reported issues:
/test/e2e/specs/editor/various/taxonomies.spec.js
Thanks a lot for the quick reviews, folks! 🙇🏻
Size Change: 0 B
Total Size: 1.81 MB
Fails are due to docker compose
will keep mashing the rerun button :trollface:
Oh! It needed a rebase after https://github.com/WordPress/gutenberg/pull/66488 should be good now.
What?
Follow up to:
This PR preloads
'/wp/v2/global-styles/' . $global_styles_id
with a context corresponding to user caps, that is,edit
for users that can edit global styles, andview
for everyone else.Why?
Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid clientside requests.
Different clientside requests fire for each.
How?
Use
current_user_can( 'edit_theme_options' )
to test for global styles edit caps. This matches post type caps.Testing Instructions
global-styles
endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_requestFor admins in the POST and SITE editors the following URLS should be preloaded:
For editors in the POST editor: