Fix Color changes to be in sync with rest of the block for latest comment

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.49k stars 4.19k forks source link

Fix Color changes to be in sync with rest of the block for latest comment #66561

Open Anuj-Rathore24 opened 3 days ago

Anuj-Rathore24 commented 3 days ago

What?

This PR solves the following issues #66536, which address that latest comment text color doesn't change color in sync with the whole block

Why?

Refreshing the page after adding latest comments and changing its color doesn't change text color again, Then only first line text color will change, Remaining text color will not change.

How?

By setting the key prop and handling null values, we ensure the block behaves as expected.

Testing Instructions

Select Latest comments block
Change its background color & text color from block settings.
Save the changes and publish the page.
View the editor side & front-end side.
Refresh the page.
Now, change block text color & background color again.

Screenshots or screencast

https://github.com/user-attachments/assets/ee24b4be-df38-4513-9bb4-754411cef1e3

github-actions[bot] commented 3 days ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 3 days ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Anuj-Rathore24 <anujrathore24@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] commented 3 days ago

:wave: Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Anuj-Rathore24! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.