Closed t-hamano closed 3 days ago
P.S. I'm adding a backport label because this issue first appeared in WP 6.7.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: +31 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/editor/index.min.js |
106 kB | +31 B (+0.03%) |
Flaky tests detected in 6d316c9ea93930a0257932cf32e4c80a6503f4e2. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
đ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11577192798 đ Reported issues:
/test/e2e/specs/site-editor/site-editor-url-navigation.spec.js
/test/e2e/specs/editor/various/taxonomies.spec.js
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: fcee21f397729a2ad3428413daa5b34e4bfb82c0
It looks like a couple of test/e2e/specs/editor/various/taxonomies.spec.js
related e2e tests became flaky after this got merged. See #59638.
Thanks for the quick fix!
What?
Why?
63491 resets the bottom margin of the
FormTokenField
component inside thePostTaxonomiesFlatTermSelector
component.PostTaxonomiesFlatTermSelector
needs space between both because most used tags may be rendered below theFormTokenField
.How?
The
PostTaxonomiesFlatTermSelector
component is publicly exposed and there may be developers who have not yet opted into__nextHasMarginBottom
. To prevent double spacing, I restore the previous spacing (12px
) via theVStack
component only if the__nextHasMarginBottom
prop is enabled.Testing Instructions