Open afercia opened 2 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: -61 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/edit-site/index.min.js |
221 kB | -43 B (-0.02%) |
build/edit-site/style-rtl.css |
13 kB | -11 B (-0.08%) |
build/edit-site/style.css |
13 kB | -7 B (-0.05%) |
Flaky tests detected in eafd7f114b4a57fa053623b54beedd23f7f607b2. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11595971690 📝 Reported issues:
/test/e2e/specs/editor/various/taxonomies.spec.js
A note on teh following components used for this UI:
They are all wrapper to other components like HStack and Text. It appears to me they are a bit overkill and not really necessary. It looks like they're only used here and the more generic component could be used instead.
Also, SidebarNavigationScreenDetailsPanelLabel and SidebarNavigationScreenDetailsPanelValue are basically duplicate.
The code could be greatly simplified by entirely removing these components.
Fixes https://github.com/WordPress/gutenberg/issues/66526 Alternative to https://github.com/WordPress/gutenberg/pull/66535
What?
The 'Last modified' button in the Site editor navigation panel > Styles is not accessible and arguably usable as the visibel text mismatches the accessible name and the button's action isn't clear.
Why?
A complete mismatch between an interactive control visible text and its accessible name is a WCAG violation. On top of that, buttons must clearly communicate the udnerlying action for all users. For more details, see the issue https://github.com/WordPress/gutenberg/issues/66526
How?
Separates the 'last modified' information from the button. Makes clearer the button is a navigation button and that it brings to 'Revisions'.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: