github-actions[bot]
commented
2 days ago The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
jasmussen
andrewserong
What?
In the abstracted post editor (i.e. editing a post or page with template preview switched off), always output the
has-global-paddingclassname for the post content area, irrespective of the layout type in use (but only if the theme supports it).Why?
This is kind of similar to https://github.com/WordPress/gutenberg/pull/66352 in some ways but addresses a slightly different problem.
Something that @jasmussen ran into while testing TT5 theme is that depending on the template, you can be in a situation where the template uses the global padding on a wrapper Group block, and the Content block is set to flow/default alignment. On the site frontend, this will mean that visually, there is some global padding being applied around the content area.
However in the abstracted post editor, there is no such wrapper block, and so the content can render to the very edge of the viewport, unexpectedly.
This PR proposes always applying the
has-global-paddingclassname so that if the site uses the global padding it applies in the abstracted post editor. Given that folks can switch on the template preview mode if they want a more WYSIWYG look, the assumption here is that it's better to optimise for things looking good for the writing experience.How?
In the
VisualEditor, output thehas-global-paddingclass name if the theme supports root padding aware alignments, we're in the post only mode, and the entity being edited is not a design one (pattern, template part, etc)Testing Instructions
This could be a little tricky to reproduce! It took me a while before I ran into the issue 😄
trunkif you use the preview in the top right and select Mobile, you'll likely see that the content unexpectedly goes edge-to-edge in the previewScreenshots or screencast