Closed ellatrix closed 2 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: -13 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/block-editor/index.min.js |
254 kB | -13 B (-0.01%) |
What?
Fixes https://github.com/WordPress/gutenberg/pull/66556#issuecomment-2449268452.
This PR skips over
wp-
core styles when looking for "compatibility" styles (that contain rules that target the canvas).Not only does this fix the warning, but it should also speed up load a tiny bit because there's less styles to parse.
Why?
Because we are responsible for adding our own styles to the iframed canvas. Note that we would be seeing warnings for all the styles not added, so we know that all of them are correctly added.
How?
We skip them.
Testing Instructions
Load the site editor and make sure there's no compat styles warning.
Testing Instructions for Keyboard
Screenshots or screencast