Closed mirka closed 10 hours ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: -44 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/components/index.min.js |
227 kB | -32 B (-0.01%) |
build/components/style-rtl.css |
12.4 kB | -4 B (-0.03%) |
build/components/style.css |
12.4 kB | -6 B (-0.05%) |
build/editor/index.min.js |
106 kB | -2 B (0%) |
Flaky tests detected in 364ffbed4459bdbe98d4136e6f952254e35e8737. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
đ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11613729725 đ Reported issues:
/test/e2e/specs/widgets/editing-widgets.spec.js
/test/e2e/specs/editor/various/inserting-blocks.spec.js
While testing, I noticed that the hover colors with a dark color scheme
Ooh, I love how you tried the color theme tool! To clarify on the status there, we were in the midst of experimenting internally with theming, and only a few components fully support all the (experimental) color parameters. Accent color theming is fully supported though, at least.
In preparation for #65751
What?
Tweak the token component so it uses fewer style overrides, as well as fix some minor style bugs when
isBorderless
.Testing Instructions
See the Storybook for FormTokenField. Test for combinations of the
disabled
andisBorderless
props.Screenshots or screencast
Default
The remove button is now a nice square using the "small" variant of Button.
Disabled
No visual changes aside from right padding on the remove button.
isBorderless & Disabled
Before
https://github.com/user-attachments/assets/296a006e-ea63-467f-8e6d-a7e404c7bfba
The token text and remove button both look interactive, even though they are disabled.
After
https://github.com/user-attachments/assets/f9648073-ee52-4da0-83b6-b07768da90a9
A version 2 of this component is planned, and a comprehensive design review would take place then, but cc @WordPress/gutenberg-design anyway for awareness.