github-actions[bot]
commented
1 day ago Size Change: +7 B (0%)
Total Size: 1.81 MB
| Filename | Size | Change |
|---|---|---|
build/core-data/index.min.js |
73.7 kB | +7 B (+0.01%) |
Closed ellatrix closed 22 hours ago
github-actions[bot]
commented
1 day ago Size Change: +7 B (0%)
Total Size: 1.81 MB
| Filename | Size | Change |
|---|---|---|
build/core-data/index.min.js |
73.7 kB | +7 B (+0.01%) |
github-actions[bot]
commented
1 day ago Flaky tests detected in 72c51966422a06c4b0e612a21ae38c6d1f448086. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
đ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11617462864 đ Reported issues:
/test/e2e/specs/widgets/customizing-widgets.spec.jsgithub-actions[bot]
commented
1 day ago The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Mamaduka
commented
1 day ago If I understand the issue correctly, the finish resolution for getEntityRecord avoids calling the resolver correctly, but this prevents entity configurations from being loaded.
ellatrix
commented
23 hours ago @Mamaduka I tested the query block on the All Archives template in trunk, and it's stuck in a loading state there too? đ¤
Mamaduka
commented
23 hours ago @ellatrix, odd. It works fine on the latest trunk, but I get an infinite loop on this branch.
ellatrix
commented
23 hours ago @Mamaduka Ah, ok, it works on the latest trunk indeed. Rebased. Must have been fixed in a different PR.
Mamaduka
commented
23 hours ago Indeed it was fixed via #66655.
What?
See https://github.com/WordPress/gutenberg/pull/66579#issuecomment-2450378831. See https://github.com/WordPress/gutenberg/pull/66647.
The problem was the the entities configs were not loaded when the template was received as an entity.
Why?
The Site Editor would not load in Safari without the temporary fix. See https://github.com/WordPress/gutenberg/pull/66579#issuecomment-2450378831.
How?
Ensure we wait for the entities config to be loaded.
Testing Instructions
Open the Site Editor in Safari.
Testing Instructions for Keyboard
Screenshots or screencast