Closed mikachan closed 1 day ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Yes, e2e tests would be good! Happy to work on that as a follow-up.
Size Change: +4 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/block-library/index.min.js |
221 kB | +4 B (0%) |
What?
Fixes an issue introduced in https://github.com/WordPress/gutenberg/pull/65820, where the Query Loop block gets stuck showing the loading spinner after being inserted.
Why?
It seems to be because we're trying to use
postTypeFromContext
when it's undefined, so we should check that it exists before running logic against it.How?
Check for
postTypeFromContext
before using it.Testing Instructions
Screenshots or screencast