Convert the emitter module in data package to TS

manzoorwanijk commented 1 day ago

What?

Like #66667, this PR converts the emitter module in the data package to TS.

Why?

It will pave the way for fixing types on other packages like data and core-data

How?

The PR simply renamed the .js files to .ts and adds the required types to the functions etc.

Testing Instructions

Just verify that the build and tests are successful

Testing Instructions for Keyboard

Screenshots or screencast

github-actions[bot] commented 1 day ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

tyxla commented 21 hours ago

Good stuff, thank you once more @manzoorwanijk 🚀

WordPress / gutenberg