Open Mamaduka opened 22 hours ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: mtias <matveb@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
cc @poojabhimani12
Size Change: -11 B (0%)
Total Size: 1.81 MB
Filename | Size | Change |
---|---|---|
build/editor/index.min.js |
106 kB | -11 B (-0.01%) |
Flaky tests detected in fc2487beceda057498ffd00f594a5896dc68d9c3. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
đ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11627378030 đ Reported issues:
/test/e2e/specs/editor/various/inserting-blocks.spec.js
To consider: unresolved comments should still be displayed on load not just when toggling the sidebar view.
@mtias that probably should be part of larger refactoring. But even based on the latest mockups, all comments seem to be contained in the sidebar.
Yeah, I think those mockups are missing the main use case
What?
I've updated the collab sidebar to only load comments when it's displayed instead of fetching them when opening the editor. Previously, a query was also made even when the experiment was disabled.
Why?
Unnecessary queries can negatively affect the editor's performance.
How?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshot