WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.49k stars 4.18k forks source link

e2e-test-utils-playwright: Increase timeout of site-editor selector #66672

Open alexflorisca opened 19 hours ago

alexflorisca commented 19 hours ago

What?

This PR increases the timeout of a selector in the e2e-test-utils-playwright package. It also fixes a typo in another timeout value

Why?

This will hopefully solve some test flakiness that we're experiencing. The site editor loads around 500 assets. It takes around 5-6 seconds on my local machine to load just the canvas for the site editor. 10s timeout here is pretty low, so I've increased it to 60s

How?

We're just increasing the timeout from 10s to 60s.

Testing Instructions

  1. Use the visitSiteEditor function from the e2e-test-utils-package in an e2e test on a slow network connection. 2. Verify that the test doesn't timeout after 10s.

Testing Instructions for Keyboard

n/a>

Screenshots or screencast

n/a

github-actions[bot] commented 19 hours ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 19 hours ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alexflorisca.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: alexflorisca.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] commented 19 hours ago

:wave: Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alexflorisca! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.