Make strings in theme.json translatable

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.49k stars 4.18k forks source link

Make strings in theme.json translatable #66675

Open d-alleyne opened 19 hours ago

d-alleyne commented 19 hours ago

What?

Aspect Ratios and Shadow Presets are untranslated. The strings aren't in GlotPress.

Why?

This PR resolves the missing Aspect Ratios in https://github.com/WordPress/gutenberg/issues/66027.

How?

By adding a symlink to theme.json in the project's root directory, strings will be extracted

Testing Instructions

Download the plugin locally.
Make POT with wp i18n make-pot ..
Inspect the generated gutenberg.pot file to confirm that the Aspect Ratio strings from theme.json are not being extracted.

N.B the shadows.presets strings are not extracted.

Testing Instructions for Keyboard

Screenshots or screencast

github-actions[bot] commented 19 hours ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 19 hours ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: d-alleyne <dalleyne@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.