Convert lock unlock to generics

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.49k stars 4.18k forks source link

Convert lock unlock to generics #66682

Open manzoorwanijk opened 17 hours ago

manzoorwanijk commented 17 hours ago

What?

Addresses the feedback given in https://github.com/WordPress/gutenberg/pull/66667#discussion_r1825958215

Why?

To allow better type support for lock and unlock functions

How?

This PR makes lock and unlock as generics to set the object type

Testing Instructions

Same as #66667

Testing Instructions for Keyboard

Screenshots or screencast

github-actions[bot] commented 17 hours ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

manzoorwanijk commented 15 hours ago

@jsnajdr Should I fix those types that are affected by the updated signature?

There are 7 errors in total, fixable by 3-4 minor changes

github-actions[bot] commented 15 hours ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.