Closed tellthemachines closed 1 week ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: +51 B (0%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
build/block-editor/index.min.js |
255 kB | +28 B (+0.01%) |
build/block-library/index.min.js |
221 kB | +23 B (+0.01%) |
Flaky tests detected in 660e7265f3c3a69c37cfa8d87f7c32859e0aa5fa. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11883548499 📝 Reported issues:
/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js
What?
Part of #66824.
Fixes a bug observed while working on #66986: dropping Images or Videos from the inserter Media tab into the Cover block media placeholder doesn't add them as background to the Cover block (which would be expected).
One of the issues was the Cover block itself not recognising media from the inserter due to it not having an explicit type. I fixed that by determining the type based on block name in the media placeholder, and appending it to the block attributes.
The other issue was that the Video block uses
src
instead ofurl
, and media placeholder wasn't handing that case. Updated to look forsrc
attributes too.Testing Instructions
Screenshots or screencast
https://github.com/user-attachments/assets/ea87233c-92dc-4ee5-b446-80f3639c4881