WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Native CI tests: update mac os image runners from `macos-12` to `macos-13` #67095

Open ramonjd opened 3 days ago

ramonjd commented 3 days ago

So basically I don't know what I'm doing.

https://github.com/actions/runner-images is a source of confusion on which xcode version supports which mac os image runner.

According to what I've found:

  1. As of November 2024, the default Xcode version on macos-13 is Xcode 15.0.1 source, and the default Xcode version on macos-14 is Xcode 15.4 source.
  2. macos-13 may default to iOS 17 runtime simulator source. Newer runners support iOS 17 runtime simulator source.

This PR is just a YOLO space. I'll wait for the experts.

What? How?

Update mac os image runners from macos-12 to ~latest~ macos-13

Why?

GitHub Actions is starting the deprecation process for macOS 12. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24

To raise awareness of the upcoming removal, we will temporarily fail jobs using macOS 12. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:

See: https://github.com/actions/runner-images/issues/10721

Testing Instructions

Behold! The native tests should pass 👀 🤞🏻

github-actions[bot] commented 3 days ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] commented 3 days ago

Flaky tests detected in ec6800ad320f5a48bc63237ba7478c6d81880c74. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11904184956 📝 Reported issues:

desrosj commented 3 days ago

"Expert" here (😅), just connecting YOLO prs: #66609. I plan to circle back to this next week after 6.7.1 this week.

ramonjd commented 3 days ago

@desrosj Thank you for saving the day!!