Closed t-hamano closed 3 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: -9 B (0%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
build/edit-site/posts-rtl.css |
7.5 kB | -6 B (-0.08%) |
build/edit-site/posts.css |
7.51 kB | -6 B (-0.08%) |
build/edit-site/style-rtl.css |
13.3 kB | +1 B (+0.01%) |
build/edit-site/style.css |
13.4 kB | +2 B (+0.01%) |
Good spot, thanks for caring about the details! Indeed I see it:
But instead of making the site hub smaller, shouldn't the header itself be 60px tall? I recognize there's even a separate conversation about making the header 64px, but at least for now, it's meant to be 60:
Related to #66171
What?
This PR changes the height of the site hub from
56px
to60px
. This fixes the appearance of a vertical scrollbar in mobile layouts.Why?
This is because the site hub is 56px tall, while the toggle icon inside is 60px tall:
Testing Instructions