Closed Mamaduka closed 21 hours ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
The following contributors have not linked their GitHub and WordPress.org accounts: @briannaneiderman, @Tmeemu.
Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Unlinked contributors: briannaneiderman, Tmeemu.
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: kraftner <kraftner@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: +3 B (0%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
build/block-library/index.min.js |
221 kB | +3 B (0%) |
One downside to this solution is that Drop Cap won't be available when multi-editing paragraphs. I'm not sure how often consumers actually need this.
Yes, I think this is ok personally.
Would be cool to have a test theme or something some e2e test where we disable everything and check the behavior of the editor.
I will try introducing a similar test without adding another custom theme to the test suite. It will most likely be later this week; meanwhile, PR is open for feedback.
I don't have time at the moment to work on e2e tests, so I'm going to merge this and handle those later.
What?
Fixes #61231.
PR prevents the typography panel from rendering with empty children without creating store subscriptions for every Paragraph block in the canvas (#56967).
Why?
The Typography panel shouldn't be rendered when a consumer disabled all options.
How?
Move
InspectorControls
withinDropCapControl
and only render it for the currently selected block.Testing Instructions
See: https://github.com/WordPress/gutenberg/issues/61231#issue-2271060554
Testing Instructions for Keyboard
Same.