search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.54k stars 4.21k forks source link

DataViews: improve names of filter operators #67124

Open oandregal opened 6 days ago

oandregal commented 6 days ago

There are six filter operators in DataViews and each one of them comes with a label:

Operator Label Description Example
is "is" EQUAL TO. The item's field is equal to a single value. Author is Admin
isNot "is not" NOT EQUAL TO. The item's field is not equal to a single value. Author is not Admin
isAny "is any" OR. The item's field is present in a list of values. Author is any: Admin, Editor
isNone "is none" NOT OR. The item's field is not present in a list of values. Author is none: Admin, Editor
isAll "is all" AND. The item's field has all of the values in the list. Category is all: Book, Review, Science Fiction
isNotAll "is not all" NOT AND. The item's field doesn't have all of the values in the list. Category is not all: Book, Review, Science Fiction

This issue is to discuss improvements to the existing labels.

Is there a better copy for them?

For example, would includes be more user friendly than is any?

How to handle singular vs plural field names

"Author is ..." works fine because the field name is singular. But what if the field was plural? We'd end up with "Authors is ...".

annezazu commented 6 days ago

Adding needs copy review to get some copy editor help :) cc @justintadlock as I know you're a great wordsmith too.

justintadlock commented 6 days ago

Just some quick thoughts at the end of the day with a less-than-fresh brain:

For example, would includes be more user friendly than is any?

Absolutely. I think the audience is developers here, so they'd likely understand either. But I'd still favor includes.

The ones I find the most confusing are isAll and isNotAll. I think that's because the example uses categories. Generally, you'd "have" a category or be "in" a category.

"Author is ..." works fine because the field name is singular. But what if the field was plural? We'd end up with "Authors is ...".

I'm guessing this is the user-facing text, so shouldn't that just be internationalized and change based on the number of authors chosen? In English, 1 author = Author is and 2 authors = Authors are. An alternative is using a colon: Authors: name(s).

It'd probably help to look at how custom post types and taxonomies handle singular vs. plural labels. There may be some existing practices to borrow from.