Closed talldan closed 1 day ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: 0 B
Total Size: 1.82 MB
Flaky tests detected in 69e30048cf61e1e3b2d83e61dda7e99811a39e23. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
๐ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11927971803 ๐ Reported issues:
/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js
It is worth adding a fail scenario to catch this in the future? Not a blocker, just asking...
I don't think there's an easy way to do that. This typo has also already caused me quite a lot of wasted time, so I'd be very happy to move on from it ๐
Thanks for the approval ๐
What?
Fixes a typo/bug in the
useBlockSync
unit tests.The typo causes
setHasControlledInnerBlocks
not to run for these tests, insteadreplaceInnerBlocks
is dispatched in place ofsetHasControlledInnerBlocks
with the args thatsetHasControlledInnerBlocks
would usually receive. This can cause some weird results, like theblocks
arg ofreplaceInnerBlocks
being a boolean value. ๐ตAmazingly the tests still work(ed) ๐คจ