Closed Mamaduka closed 2 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: +1 B (0%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
build/edit-site/index.min.js |
219 kB | +1 B (0%) |
Thank you, Dave!
What?
This is a follow-up to #66023.
Update the
ScreenStyleVariations
component to dispatch thesetDeviceType
action inside effect instead of render.Why?
React might re-render or call components for various reasons; there's no need to dispatch action every time it happens.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast